RDKEMW-12004 : Middleware leak m_drmConfigParam = new configs() #844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a memory leak in the DrmSessionManager class by properly deleting the m_drmConfigParam object in the destructor. The configs object is allocated with new in the constructor (line 67) but was previously not being freed, resulting in a memory leak on every DrmSessionManager destruction.
Changes:
- Added
MW_SAFE_DELETE(m_drmConfigParam)to the DrmSessionManager destructor to properly free the allocated memory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RDKEMW-12004 : Middleware leak m_drmConfigParam = new configs()
Reason for change: Resolved memory leak issue
Test Procedure: Refer ticket
Risks: Medium
Priority: P1
Signed-off-by: Rekha Kandhavelan [rekha_kandhavelan@Comcast.com]